Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe UnkData5 should be "ItemIngredient" #35

Open
highlyunavailable opened this issue Dec 27, 2021 · 2 comments
Open

Recipe UnkData5 should be "ItemIngredient" #35

highlyunavailable opened this issue Dec 27, 2021 · 2 comments

Comments

@highlyunavailable
Copy link

highlyunavailable commented Dec 27, 2021

The Recipe type in Lumina.Excel.GeneratedSheets (6.0.2 from nuget) has a property UnkData5 which is an array of RecipeUnkData5Obj - these are ItemIngredients and should be called such.

The SaintCoinach def file appears to be correctly naming these - is there anything I can do to help get the proper name into this library? It appears those classes are generated so it doesn't look like a PR to fix the code directly is the best option.

@highlyunavailable
Copy link
Author

Looks like this may be part of #8 - it's certainly a repeat that is nested.

@NotAdam
Copy link
Owner

NotAdam commented Dec 28, 2021

this ultimately comes down to the fact that the upstream schema is incredibly difficult to work with and I haven't bothered to fix it as a result

there's some WIP stuff here for a new schema format that's easier to edit and provides structural features that are missing in SC which make it incredibly difficult to generate anything that's usable, but I haven't made much progress on that front yet as I've been a bit busy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants