Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOK and FSK should be both supported without the need of recompilation #167

Open
serialrf433 opened this issue Jan 22, 2025 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@serialrf433
Copy link
Contributor

Current Situation

Currently you are forced to choose if OOK or FSK is enabled. This is not what most users coming from rtl_433 expect. I was surprised why my reception (FSK transmitter) was not working. I had to spend much time to understand that for some unknown reason there is a switch between OOK and FSK rtl_433_esp .
In platformio.ini there is:
'-DOOK_MODULATION=true' ; False is FSK, True is OOK

Proposed Change

Please remove the need of
'-DOOK_MODULATION=true' ; False is FSK, True is OOK

OOK and FSK should be both just working at same time like known from the rtl_433 project users.

Additional Context

No response

@serialrf433 serialrf433 added the enhancement New feature or request label Jan 22, 2025
@NorthernMan54
Copy link
Owner

The requirement to select FSK or OOK modulation is needed to tell the radio chipset which mode to operate in.

@serialrf433
Copy link
Contributor Author

I think my request was a step too far.
I understand that selection of FSK or OOK is required for a typical radio chipset. I was using SDR most time and that is why i was thinking both reception types would be possible at the same time.

Its not that simple on bigger projects using this rtl_433_esp libraty to recompile the whole project with this library when a switch from OOK to FSK is required.
Could you still remove the need of '-DOOK_MODULATION=true' and solve that way the need of recompilation? The library should be able to use FSK and OOK when compiled by default. Some option to switch between both would be great.

Most devices today use FSK. But OOK is default on this library. I expect many people would want to use FSK instead of OOK.

@serialrf433 serialrf433 changed the title OOK and FSK should be both supported at the same time OOK and FSK should be both supported without the need of recompilation Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants