From 7de9e6a2204220d139a33260143c5f16a562548f Mon Sep 17 00:00:00 2001
From: Agost Biro <agostbiro@gmail.com>
Date: Thu, 30 Jan 2025 15:44:46 +0000
Subject: [PATCH 1/2] ci: upgrade upload/download artifacts to v4

---
 .github/workflows/edr-npm-release.yml | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/edr-npm-release.yml b/.github/workflows/edr-npm-release.yml
index 3118dcefb..870de40c3 100644
--- a/.github/workflows/edr-npm-release.yml
+++ b/.github/workflows/edr-npm-release.yml
@@ -144,12 +144,13 @@ jobs:
         if: ${{ !matrix.settings.docker }}
         shell: bash
       - name: Upload artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: bindings-${{ matrix.settings.target }}
           # The upload artifact action doesn't respect the working directory setting. Unclear if this is a bug or not
           # https://github.com/actions/upload-artifact/issues/294
           path: ./crates/edr_napi/${{ env.APP_NAME }}.*.node
+          overwrite: true
           if-no-files-found: error
   test-macOS-windows-binding:
     name: Test bindings on ${{ matrix.settings.target }} - node@${{ matrix.node }}
@@ -178,7 +179,7 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile --prefer-offline
       - name: Download artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: bindings-${{ matrix.settings.target }}
           path: ./crates/edr_napi/
@@ -204,7 +205,7 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile --prefer-offline
       - name: Download artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: bindings-x86_64-unknown-linux-gnu
           path: ./crates/edr_napi/
@@ -236,7 +237,7 @@ jobs:
           pnpm config set supportedArchitectures.libc "musl"
           pnpm install --frozen-lockfile --prefer-offline
       - name: Download artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: bindings-x86_64-unknown-linux-musl
           path: ./crates/edr_napi/
@@ -262,7 +263,7 @@ jobs:
         with:
           version: 9
       - name: Download artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: bindings-aarch64-unknown-linux-gnu
           path: ./crates/edr_napi/
@@ -306,7 +307,7 @@ jobs:
         with:
           version: 9
       - name: Download artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: bindings-aarch64-unknown-linux-musl
           path: ./crates/edr_napi/
@@ -377,7 +378,7 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile --prefer-offline
       - name: Download all artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           path: ./crates/edr_napi/artifacts
       - name: Check number of artifacts

From be88de58b90ac0e6897f45a8a5b9bb57d36922f6 Mon Sep 17 00:00:00 2001
From: Agost Biro <5764438+agostbiro@users.noreply.github.com>
Date: Thu, 30 Jan 2025 16:57:27 +0100
Subject: [PATCH 2/2] Update .github/workflows/edr-npm-release.yml

Co-authored-by: Piotr Galar <piotr.galar@gmail.com>
---
 .github/workflows/edr-npm-release.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.github/workflows/edr-npm-release.yml b/.github/workflows/edr-npm-release.yml
index 870de40c3..bb1d75064 100644
--- a/.github/workflows/edr-npm-release.yml
+++ b/.github/workflows/edr-npm-release.yml
@@ -150,7 +150,6 @@ jobs:
           # The upload artifact action doesn't respect the working directory setting. Unclear if this is a bug or not
           # https://github.com/actions/upload-artifact/issues/294
           path: ./crates/edr_napi/${{ env.APP_NAME }}.*.node
-          overwrite: true
           if-no-files-found: error
   test-macOS-windows-binding:
     name: Test bindings on ${{ matrix.settings.target }} - node@${{ matrix.node }}