-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure statsforecast can run with PYTHONOPTIMIZE=2 #977
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
caa2e56
to
c6364cd
Compare
Thanks! Can you please export the notebooks (run Alternatively you can just install the pre-commit hooks as described in our contributing guide and that'll export them. |
c6364cd
to
862b2ed
Compare
@jmoralez ah yes sorry I missed that step - I had some trouble with the pre-commit hooks, but I've managed to generate the files manually now. |
CodSpeed Performance ReportMerging #977 will not alter performanceComparing Summary
|
@jmoralez I see that some checks are failing.
When I ran nbdev locally it did generate some python files for notebooks I hadn't touched - but one of those generated files had some mypy errors:
So I just commit the python files for the two notebooks I had touched. I guess the fact that nbdev is generating more files is the reason for the CI failure? Do you have some idea what might be happening here? |
We use a specific version of nbdev Line 24 in 52a5c9a
so you have to set up the environment as described in the contributing guidelines, or I can fix the linting errors if you want. |
Fix for #976