Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collector Number #=0 defaults to default printing when specified #70

Closed
RivalRowan opened this issue Jan 11, 2025 · 1 comment
Closed

Comments

@RivalRowan
Copy link

Hi Nils,
This is a hyper-specific bug for the serialized 001/001 The One Ring due to Scryfall having assigned it the collector number of "0".

Calling for the specific card version {{card|The One Ring||LTR|#=0}} will instead return the Scryfall default printing (i.e. the equivalent to {{card|The One Ring}}). For pretty much every other card, this is fine behaviour. But for The One Ring, this means it's not possible to call the 001/001 serialized version.

A demonstration of this can be seen in the Notes section of the table on the MTG Wiki Serial numbered card.

I'm not sure this is fixable from a ScryfallLinks side without breaking everything. Might be a Scryfall fix, I'm not sure.

@NilsEnevoldsen
Copy link
Owner

I think this is the bug. This should be a nullish coalescing operator (??) rather than a ternary operator (?).

$cnquery = $cn ? ' cn:' . $cn : '';

Same line of code that needs to be updated for #69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants