Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Think about behavior on touch #11

Open
NilsEnevoldsen opened this issue Nov 15, 2017 · 3 comments
Open

Think about behavior on touch #11

NilsEnevoldsen opened this issue Nov 15, 2017 · 3 comments
Labels
bug help wanted

Comments

@NilsEnevoldsen
Copy link
Owner

Should tooltip open on tap? Then image links to SF?

Should image also be link to SF on desktop?
@soundslocke
Copy link
Contributor

I'd say "yes" to all those questions!

Repository owner deleted a comment from JOHNJOHNGENTRY Nov 16, 2017
NilsEnevoldsen added a commit that referenced this issue Nov 17, 2017
@NilsEnevoldsen
Link image to Scryfall
9038cf4 
Work on #11
@NilsEnevoldsen
Copy link
Owner Author

https://www.html5rocks.com/en/mobile/touchandmouse/#toc-together

@NilsEnevoldsen
Copy link
Owner Author

This might be improved with newer versions of popper/tippy. Need to take a look at them.

@NilsEnevoldsen NilsEnevoldsen mentioned this issue Sep 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NilsEnevoldsen @soundslocke