You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was looking through the code and trying to understand it, particularly regarding the interpolation and control part. I was going through the "_to_accelerated_time" and something seemed off when I saw that the "_2Vmax_per_a" parameter was calculated only for one axis but used for all of them. This is being done in the "iter" function:
Basically it is only calculated for the axis with the maximum velocity and then applied for each axis separately.
Doesn't it mean that the "_to_accelerated_time" function would give incorrect results for all axis except the one with the maximum velocity?
I might be wrong about this, so please do correct me if I am wrong.
A possible solution would be to have 3 values about the "_Vmax_per_a" parameter:
Hi Nikolay
Great work on this project!
I was looking through the code and trying to understand it, particularly regarding the interpolation and control part. I was going through the "_to_accelerated_time" and something seemed off when I saw that the "_2Vmax_per_a" parameter was calculated only for one axis but used for all of them. This is being done in the "iter" function:
Basically it is only calculated for the axis with the maximum velocity and then applied for each axis separately.
Doesn't it mean that the "_to_accelerated_time" function would give incorrect results for all axis except the one with the maximum velocity?
I might be wrong about this, so please do correct me if I am wrong.
A possible solution would be to have 3 values about the "_Vmax_per_a" parameter:
and then using the exact value for the appropriate axis in the "_to_accelerated_time" function.
The text was updated successfully, but these errors were encountered: