Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular CCW movement in same quadrant #35

Open
vsiz opened this issue Feb 17, 2019 · 0 comments
Open

Circular CCW movement in same quadrant #35

vsiz opened this issue Feb 17, 2019 · 0 comments

Comments

@vsiz
Copy link

vsiz commented Feb 17, 2019

In the pulse calculation of the circular movement, it looks like the number of pulses of a CCW move in the same quadrant is always the number of pulses of a whole circle :

  • in a CCW movement in the same quadrant, the start angle is always bigger than the end angle
  • 2*PI is added in that case, which fulfills the condition of delta quadrant is >= 4
  • in that case the number of pulses is assigned to the number of pulses of a whole circle
  • this results in an invalid movement after the expected move (can be quite scary :-) )
    Solution for me was removing the condition "if quarter_end - quarter_start >= 4:" and always doing the "else:" in the class PulseGeneratorCircular(PulseGenerator) init method.
    I am not sure if full circles are still accepted, but for me that's not an issue since I always split up full circles into segments during g-code generation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant