Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoticon identified where it should not have been #34

Open
CFLJacquet opened this issue Oct 21, 2021 · 2 comments
Open

Emoticon identified where it should not have been #34

CFLJacquet opened this issue Oct 21, 2021 · 2 comments

Comments

@CFLJacquet
Copy link

Describe the bug
The emoticon D: is found in "Ticket ID: 99" where it should not have been.

To Reproduce
Steps to reproduce the behavior:

import emot
emot_extractor = emot.core.emot() 

text = """Ticket ID: 99"""
emoticons = emot_extractor.emoticons(text)

>>> {'value': ['D:'], 'location': [[8, 10]], 'mean': ['Sadness'], 'flag': True}

Expected behavior
Nothing should be found

Desktop (please complete the following information):

  • OS: ubuntu 18.04
  • Version emot=2.1 and emot=3.1
@NeelShah18 NeelShah18 self-assigned this Oct 22, 2021
@NeelShah18
Copy link
Owner

Yep, It look like due to new pattern optimization algorithm. To create one single universal pattern makes it is really difficult find edge case. Let me see how we can make pattern which can avoid this issue. Thank you for reporting it.

@CFLJacquet
Copy link
Author

Thanks for creating that repo, it's super useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants