Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup resulting standards space types for blend space types from model #99

Open
DavidGoldwasser opened this issue Apr 19, 2022 · 0 comments
Assignees

Comments

@DavidGoldwasser
Copy link
Collaborator

DavidGoldwasser commented Apr 19, 2022

It looks like it may grab the standards building type and standards space type from either the first space type. This should either be stripped out or should be changed to whatever building type or space type represents the largest portion fo the space type. I think its cleaner to strip it out to avoid confusion. The screenshot below shows current state. This happens downstream and doesn't generally impact other measures that change the model (but someone could try to use it that way). It was creating confusing results for generic_qaqc measure that was providing comparison values for those space types.

I may use building and space type each named Blended. If there is an easy way to check if all space types had the same building type, but I think the building type tag an be primary fallback here.

Screen Shot 2022-04-19 at 3 39 07 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant