Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radiance_measure requires glare sensor #93

Open
Ski90Moo opened this issue Feb 17, 2022 · 2 comments
Open

radiance_measure requires glare sensor #93

Ski90Moo opened this issue Feb 17, 2022 · 2 comments

Comments

@Ski90Moo
Copy link
Contributor

I am not sure if this is an issue, but it appears that the radiance_measure requires a glare sensor to properly execute. If the OpenStudio model does not have a glare sensor installed, it will run radiance, but it seems the information is never passed to EnergyPlus for simulation.

@jmarrec
Copy link

jmarrec commented Feb 18, 2022

t_radGlareSensorViews[space_name].each do |sensor, v|

To work with the case where there are none, looks like it should be

-          t_radGlareSensorViews[space_name].each do |sensor, v|
+          t_radGlareSensorViews[space_name]&.each do |sensor, v|

or the same construct as this one:

if t_radGlareSensorViews[space_name] && !t_radGlareSensorViews[space_name].keys.empty?
t_radGlareSensorViews[space_name].each do |sensor, views|

or move that inside that block that starts on L1282 actually

@Ski90Moo
Copy link
Contributor Author

Ski90Moo commented Mar 2, 2022

t_radGlareSensorViews[space_name].each do |sensor, v|

To work with the case where there are none, looks like it should be

-          t_radGlareSensorViews[space_name].each do |sensor, v|
+          t_radGlareSensorViews[space_name]&.each do |sensor, v|

This seems to work. It allows radiance to run without a glare sensor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants