Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exl_spaces_not_incl_fl_area argument isn't functioning anymore in wwr measure #107

Open
DavidGoldwasser opened this issue Jul 22, 2022 · 0 comments
Open

exl_spaces_not_incl_fl_area argument isn't functioning anymore in wwr measure #107

DavidGoldwasser opened this issue Jul 22, 2022 · 0 comments
Assignees
@MatthewSteen

Comments

@DavidGoldwasser
Copy link
Collaborator

DavidGoldwasser commented Jul 22, 2022 •
edited
Loading

there is code in for argument here
https://github.com/NREL/openstudio-model-articulation-gem/blob/develop/lib/measures/SetWindowToWallRatioByFacade/measure.rb#L199-L212

But the surfaces variable isn't used anymore, find place(s) where surfaces are gathered to include this logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatthewSteen MatthewSteen

Labels
None yet
Projects
OpenStudio Measure Gems
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavidGoldwasser @MatthewSteen