Implement power flow-specific (re)active power limits proxies #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-lara
approved these changes
Jan 16, 2025
|
@GabrielKS does this need a release of PSY? |
No, this PR is independent of PSY. There are still those bugs we identified in PSY but these don't call the problematic methods over there. The test failure is coming from |
This was referenced Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39 by implementing the functions
get_reactive_power_limits_for_power_flowandget_active_power_limits_for_power_flow. In all normal cases, these just redirect to PSY'sget_reactive_power_limitsandget_active_power_limits. In a few special cases, each either detailed at #39 (comment) or already implemented elsewhere in the codebase, they instead return a proxy value to effect the behavior we want.