Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove # comments from __init__.py #34

Open
bhlevca opened this issue Dec 8, 2024 · 4 comments
Open

remove # comments from __init__.py #34

bhlevca opened this issue Dec 8, 2024 · 4 comments

Comments

@bhlevca
Copy link

bhlevca commented Dec 8, 2024

Pyserve in WebGNOMEAPI fails at startup because the GetUnitName was commented out.

Did anyone check before commenting out? Is there a trick that I am missing?

from .unit_conversion import (UnitConversionError,
InvalidUnitError,
InvalidUnitTypeError,
NotSupportedUnitError,
is_same_unit,
is_supported,
is_supported_unit,
get_supported_names,
get_unit_types,
get_primary_name,
get_abbreviation,
# not sure these should be used externally
FindUnitTypes,
GetUnitTypes,
GetUnitNames,
GetUnitAbbreviation,
ConverterClass,
Converters,
UNIT_TYPES,
Simplify,
DensityConverterClass,
TempConverterClass,
LatLongConverter,
OilQuantityConverter,
convert,
)

@ChrisBarker-NOAA
Copy link
Contributor

Sorry about that -- yes, we checked, but there was some of our code that did use the "internal" API -- that has been updated.

So this is a bug in the webGNOME API that has been fixed, but it looks like we haven't pushed the latest to gitHUb in a while. I'll go do that now.

@ChrisBarker-NOAA
Copy link
Contributor

NOTE: if you can't update webgnomeapi, then you can pin pynucos to an older version, before this change.

@ChrisBarker-NOAA
Copy link
Contributor

OK -- webGNOME API has been updated with the latest versions of:

develop
main
production

branches.

@ChrisBarker-NOAA
Copy link
Contributor

Please re-open this issue if you have any further issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants