Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up in-line post test procedure #273

Open
WenMeng-NOAA opened this issue Mar 2, 2021 · 7 comments
Open

Set up in-line post test procedure #273

WenMeng-NOAA opened this issue Mar 2, 2021 · 7 comments
Assignees
@JesseMeng-NOAA @BoCui-NOAA
Labels
enhancement New feature or request

Comments

@WenMeng-NOAA
Copy link
Collaborator

The current UPP regression test package has pe tests only. With more ufs-weather-model based applications adapting in-line post, the procedure of in-line post with threading is needed.
@HuiyaChuang-NOAA
Copy link
Collaborator

Jesse and Bo have been tasked to add in-line post as part of UPP re-regression tests:
https://vlab.ncep.noaa.gov/redmine/issues/88708
https://vlab.ncep.noaa.gov/redmine/issues/88709

@HuiyaChuang-NOAA HuiyaChuang-NOAA added the enhancement New feature or request label Mar 3, 2021
@WenMeng-NOAA
Copy link
Collaborator Author

Bo set up the regional inline post procedure at
https://docs.google.com/document/d/1rLISW-2Ujg04VVUk-M99D6-QKZZ_C2PmB8c0JOwsEnM/edit?ts=608969ff

@WenMeng-NOAA
Copy link
Collaborator Author

Jesse set up the global inline post procedure at
https://docs.google.com/document/d/1Ja8xs5pN31PfuLOBDB76IuobJHgrVt-V3B1YKlIGgw4/edit?ts=608ac829

@BoCui-NOAA
Copy link
Contributor

Generate the executable from ufs-weather-model by choosing compile option CCPP suite: RRFS_v1beta (close to current parallel run).

Has tested RRFS inline post using multiple thread counts, thread number is set as 1, 2 ,3 and 4 respectively. The results including forecast nc files and Grb files are identical. No changed results were found.

EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this issue Dec 14, 2022
@gsketefian
Update GSD_HRRR3km grid parameters and enable its use in NCO mode (NO…
7bc40c0 
…AA-EMC#273)

## Description of changes:

* Update grid parameters of GSD_HRRR3km grid of type JPgrid (including its task layout and blocksize) and enable running with it in NCO mode.  The new grid parameters are set to values specified by Christina Holt of GSL.  
* Update the write-component grid parameters associated with this grid such that the former is within the latter.
* Add two WE2E tests in NCO mode to run on this grid -- one using FV3GFS for ICs and LBCs (nco_GSD_HRRR3km_FV3GFS_FV3GFS) and another using HRRRX for ICs and RAPX for LBCs (nco_GSD_HRRR3km_HRRRX_RAPX).  First test works but the second doesn't due to a yet-unknown problem in chgres_cube, but the test may work with an older executable that GSL will use.
* Bug fix: Add the FV3GFS_2017_gfdlmp_regional physics suite to the if-statements in exregional_make_ics.sh and exregional_make_lbcs.sh that set numsoil_out.
* Improvement: Add "else" clauses to the if-statements in exregional_make_ics.sh and exregional_make_lbcs.sh that check for the physics suite to set various parameters.  These "else" clauses print out an error message whenever the specified physics suite is not covered by the if-statement.

## Tests conducted:

### On hera:
Ran all the WE2E tests including the two new ones (nco_GSD_HRRR3km_FV3GFS_FV3GFS and nco_GSD_HRRR3km_HRRRX_RAPX).  All tests except regional_010 pass (regional_010 test was already broken in the original develop branch).

### On jet:
Ran the two new WE2E tests nco_GSD_HRRR3km_FV3GFS_FV3GFS and nco_GSD_HRRR3km_HRRRX_RAPX as well as regional_002 and regional_003.  All passed, although some tasks (make_lbcs and run_fcst) for the nco_GSD_HRRR3km_FV3GFS_FV3GFS and nco_GSD_HRRR3km_HRRRX_RAPX tests took more than 1 try to succeed.  Also tested versions of nco_GSD_HRRR3km_FV3GFS_FV3GFS and nco_GSD_HRRR3km_HRRRX_RAPX in which the external files are staged.  Again, both succeeded but some tasks take more than 1 try to succeed.
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this issue Dec 14, 2022
@gsketefian
Bugfix to PR NOAA-EMC#273 for running on the GSD_HRRR3km grid in NCO …
69d6920 
…mode (NOAA-EMC#276)

## DESCRIPTION OF CHANGES:
Changes to three WE2E tests needed to run successfully on hera that were left out of PR NOAA-EMC#273.

## TESTS CONDUCTED:
Same as PR#273.
@gspetro-NOAA
Copy link
Collaborator

@WenMeng-NOAA Is this issue deprecated by the new RT system we have? Or does this still need work?

@WenMeng-NOAA
Copy link
Collaborator Author

@gspetro-NOAA The work will be done on the EMC side. At this time, please keep this issue open.

@BoCui-NOAA
Copy link
Contributor

Bo set up the regional inline post procedure at https://docs.google.com/document/d/1rLISW-2Ujg04VVUk-M99D6-QKZZ_C2PmB8c0JOwsEnM/edit?ts=608969ff

I updated the document with the new file save paths due to the computer was transferred from WCOSS1 to WCOSS2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JesseMeng-NOAA JesseMeng-NOAA

@BoCui-NOAA BoCui-NOAA

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@WenMeng-NOAA @JesseMeng-NOAA @BoCui-NOAA @HuiyaChuang-NOAA @gspetro-NOAA