Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate feasability multiple Python-from-Rust packages #419

Open
felixhekhorn opened this issue Oct 21, 2024 · 1 comment
Open

Investigate feasability multiple Python-from-Rust packages #419

felixhekhorn opened this issue Oct 21, 2024 · 1 comment
Labels
benchmarks Benchmark (or infrastructure) related rust Rust extension related

Comments

@felixhekhorn
Copy link
Contributor

after #384 has been solved, we could investigate the possibility to ship multiple Python packages corresponding to the different Rust crates (e.g. ekore, dekoder). This feature may become complicated in the deployment - @alecandido tried in the past and didn't find an easy solution. For example consistent versioning might be a problem (but it is non-trivial already https://github.com/NNPDF/eko/blob/77d99363df23382bd3b7a3fa513bba213767d77c/crates/bump-versions.py ).

The current version of having a single Python packages (eko-rs) is not too bad - it is just potentially too big

@felixhekhorn felixhekhorn added benchmarks Benchmark (or infrastructure) related rust Rust extension related labels Oct 21, 2024
@alecandido
Copy link
Member

Consider that even NumPy and SciPy are shipping a single package containing different sub-packages, possibly covering different scopes.

My opinion is that, unless that's a proven bottleneck, you may ignore the issue. Though, you may want to monitor whether there are easy solutions available, just to keep it as an alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks Benchmark (or infrastructure) related rust Rust extension related
Projects
None yet
Development

No branches or pull requests

2 participants