Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Serializers #1128

Open
CarsonDavis opened this issue Dec 10, 2024 · 0 comments
Open

Refactor Serializers #1128

CarsonDavis opened this issue Dec 10, 2024 · 0 comments
Assignees

Comments

@CarsonDavis
Copy link
Collaborator

CarsonDavis commented Dec 10, 2024

Description

We would like to remove the delta_urls_count, curated_urls_count, match_pattern_type from the DeltaURLSerializer and CuratedURLSerializer. This requires more investigation.
These columns are used as hidden columns in the JS. DataTables stores these as hidden columns and the JS reads from this when performing the delete operations.

Implementation Considerations

If we want to remove these fields, we'd need to:

  • Restructure how pattern deletion works
  • Find another way to get the count and type info when needed
  • Remove the columns from DataTables config
  • Update all JavaScript that references these values
@CarsonDavis CarsonDavis self-assigned this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants