Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12.2] Exclude FakePlayers from DamageHandler::onLivingDamage for the Blessed attribute #284

Open
Pinhead-Larry opened this issue Oct 23, 2021 · 1 comment

Comments

@Pinhead-Larry
Copy link

Hi, thank you for your time.
I've been encountering a crash due to a mod incompatibility with LittleMaidMob (https://github.com/firis-games/LittleMaidReengagedFirisPatch)
The author says that it's due to the effect BLESSED, where the player counterattacks with fire when attacked by undead. The mobs from LittleMaidMob are "disguised" as players he said, and so the game crashes because it doesn't know how to handle it when they are attacked.
I can confirm this, as the game only crashes when the mobs from LittleMaids are attacked by undead mobs.

(https://github.com/firis-games/LittleMaidReengagedFirisPatch/issues/71) (Google translate)

He said that it will be nearly impossible to fix on their mod side, but easy on MysticalWorlds side. Is it possible for this to be fixed? Thank you.
crash-2021-10-23_03.02.34-server.txt
.

@noobanidus
Copy link
Collaborator

I can add a check for fake players, sure.

@noobanidus noobanidus changed the title 1.12.2 Ticking entity crash with LittleMaidMob mod [1.12.2] Exclude FakePlayers from DamageHandler::onLivingDamage for the Blessed attribute Oct 23, 2021
noobanidus added a commit that referenced this issue Dec 17, 2021
Goujer added a commit to Goujer/MysticalWorld that referenced this issue Apr 2, 2023
Try catch for Null Pointer Exception that would occur when an attribute is not part of the attribute map.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants