Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling to the API request #13

Open
krisgesling opened this issue Aug 12, 2021 · 2 comments
Open

Add error handling to the API request #13

krisgesling opened this issue Aug 12, 2021 · 2 comments

Comments

@krisgesling
Copy link
Contributor

Currently no error handling. Unlikely but does happen. Could be DDG service down, or a local network error, etc.

@mcdonc
Copy link

mcdonc commented Sep 13, 2021

I'm presuming that "API request" means the disambiguation request that doesn't use the ddg package here https://github.com/MycroftAI/fallback-duckduckgo/blob/21.02/__init__.py#L128 ? Or maybe Ken changed stuff enough since this issue was created that it's less relevant?

@krisgesling
Copy link
Contributor Author

Yeah that's the one.

What happens if we pass a failed request response to ddg.Results()?

If we get None and that is handled properly then we're all good. If not we just want to handle it appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants