You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In other words, there no validation that the user saved the file successfully, it just assumes, which is not best practice here. Instead it should check the status of saving process and only set Notpad.editors.setIsSaved(Notpad.editors.getActive().id, true); if it was successfully saved to local.
👋 Hi @Muhammed-Rahif! Thank you for taking the time to report an issue in Notpad.
We’ll dive into it shortly. 🕵️♂️🔧
While you're here, why not add a ⭐ to the repo? Click here to star.
Your support helps us grow this project and reach more awesome contributors like you! 🚀
In the below lines of code users can start saving the file but not successfully complete saving the file (eg: cancelling the save popup).
Notpad/src/lib/helpers/menubar/file-options.ts
Lines 241 to 250 in f28b5f5
In other words, there no validation that the user saved the file successfully, it just assumes, which is not best practice here. Instead it should check the status of saving process and only set
Notpad.editors.setIsSaved(Notpad.editors.getActive().id, true);
if it was successfully saved to local.This can't be achieved in web browsers as stated here: https://stackoverflow.com/questions/41334881/detect-when-user-accepts-to-download-a-file
The text was updated successfully, but these errors were encountered: