Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Plugins showing installed when not #1219

Closed
tdashworth opened this issue Feb 6, 2023 · 9 comments
Closed

[BUG] Plugins showing installed when not #1219

tdashworth opened this issue Feb 6, 2023 · 9 comments
Labels

Comments

@tdashworth
Copy link

Describe the bug
Our plugin "CDS Data Migrator" is showing as installed enough though it's not. When I try to install it, it doesn't (the NugetPlugins folder is updated but that's all).

To Reproduce
Do a clean install of XrmToolBox. See the plugin is showing as installed. Notice that when installing, it doesn't change things

Expected behavior
Install to work.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • XrmToolbox Version 1.2023.1.63
  • Tool version 2.0.0 onwards

Additional context
Add any other context about the problem here.

@tdashworth tdashworth added the bug label Feb 6, 2023
@tdashworth
Copy link
Author

@MscrmTools
Copy link
Owner

MscrmTools commented Feb 6, 2023

The issue in your repository seems to indicates the issue is with the legacy tools library.
The new tool library should handle this better. The issue was due to version comparison between file version on 4 numbers and Nuget package version on 3 numbers (semantic)
Please tell me if new tool library works better or not

@tdashworth
Copy link
Author

Thanks for the quick response!

I'll take a look tomorrow.

What do you mean by "file version"?

@MscrmTools
Copy link
Owner

Right click on tool assembly -> properties.
You can see the version in the details tab

@tdashworth
Copy link
Author

Ah, yes, we use GitVersion so the "Assembly File Version" and "Nuget Version" are different formats. Should these match? e.g. 2.0.5.0 for both?

@tdashworth
Copy link
Author

FYI, the new tool library (LOVE IT) doesn't improve things... While it lists the previous versions, the same behaviour occurs (claims it's installed but silently fails to install).

@MscrmTools
Copy link
Owner

Ok, I will debug this tomorrow and let you know my findings

@MscrmTools
Copy link
Owner

I can see you released an update to your tool and I don't reproduce the issue:
image

CDS Data migrator is not installed and displayed as installable

@tdashworth
Copy link
Author

Hi,

Things are looking good for me too.

What might have changed apart from releasing a new version? We upgraded our visual studio solutions to the vs17 style - could that have caused it? (v2.0.4 reverted that change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants