Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests are only run against a single version of Python on the main branch. #82

Open
fpgmaas opened this issue Oct 18, 2023 · 1 comment
Open

Unit tests are only run against a single version of Python on the main branch. #82

fpgmaas opened this issue Oct 18, 2023 · 1 comment

Comments

@fpgmaas
Copy link
Collaborator

fpgmaas commented Oct 18, 2023 •
edited
Loading

I think it could be useful to run unit tests against multiple versions of Python on each PR, to gain extra confidence in the proposed changes of a PR. This also builds extra confidence that chispa actually works on the python versions as specified in pyproject.toml, and could prevent issues such as #78 in the future.

I have created a draft PR to solve this; #81
@fpgmaas fpgmaas mentioned this issue Oct 18, 2023
Merged
@Fixer38
Copy link

Fixer38 commented Jan 7, 2025

As I've been reading through the issues I believe this can be marked as closed as the current unit tests are ran against this set of python versions ["3.8", "3.9", "3.10", "3.11", "3.12"] since PR #81 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fpgmaas @Fixer38