From dc1e9a759a8c842a05efa6bc577885da2c2a35ce Mon Sep 17 00:00:00 2001
From: nicolaschapur <nicolaschapur@sirius.com.ar>
Date: Fri, 14 Jun 2024 13:07:52 -0300
Subject: [PATCH 1/6] [NC]: Adds recursive function to get updated storage
 recordings

---
 .../content/Popup/CreateDemo/DemoItem.tsx     |  8 +++++---
 .../content/Popup/CreateDemo/index.tsx        | 19 +++++++++++++++----
 2 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/apps/mocksi-lite/content/Popup/CreateDemo/DemoItem.tsx b/apps/mocksi-lite/content/Popup/CreateDemo/DemoItem.tsx
index 660e3f2c..77bbd420 100644
--- a/apps/mocksi-lite/content/Popup/CreateDemo/DemoItem.tsx
+++ b/apps/mocksi-lite/content/Popup/CreateDemo/DemoItem.tsx
@@ -26,9 +26,11 @@ const DemoItem = ({
 
 	return (
 		<div className={"flex justify-between w-full px-6"}>
-			<div>
-				<TextField variant={"title"}>{demo_name}</TextField>
-				<TextField>{customer_name}</TextField>
+			<div className={"w-[200px]"}>
+				<TextField variant={"title"} className={"truncate"}>
+					{demo_name}
+				</TextField>
+				<TextField className={"truncate"}>{customer_name}</TextField>
 			</div>
 			<div className={"flex gap-3"}>
 				<Button
diff --git a/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx b/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
index cf2a046b..ac9d88fb 100644
--- a/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
+++ b/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
@@ -18,11 +18,22 @@ const CreateDemo = ({
 	setState,
 }: CreateDemoProps) => {
 	const [recordings, setRecordings] = useState<Recording[]>([]);
+
+	const getRecordings = async () => {
+		const results = await chrome.storage.local.get(["recordings"]);
+		const newRecordings = JSON.parse(results.recordings);
+		if (newRecordings.length === recordings.length) {
+			getRecordings();
+		} else {
+			setRecordings(newRecordings);
+		}
+	};
+
 	useEffect(() => {
-		chrome.storage.local.get(["recordings"], (results) =>
-			setRecordings(JSON.parse(results.recordings) ?? []),
-		);
-	}, []);
+		if (!createForm) {
+			getRecordings();
+		}
+	}, [createForm, getRecordings]);
 
 	const handleCancelClick = (recordings?: Recording[]) => {
 		if (recordings) setRecordings(recordings);

From 064c9473f87f120b0f45e98c5d67d61e0cfa4583 Mon Sep 17 00:00:00 2001
From: nicolaschapur <nicolaschapur@sirius.com.ar>
Date: Fri, 14 Jun 2024 13:11:40 -0300
Subject: [PATCH 2/6] [NC]: Adds dependency fix

---
 apps/mocksi-lite/content/Popup/CreateDemo/index.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx b/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
index ac9d88fb..1a531dc7 100644
--- a/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
+++ b/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
@@ -33,7 +33,7 @@ const CreateDemo = ({
 		if (!createForm) {
 			getRecordings();
 		}
-	}, [createForm, getRecordings]);
+	}, [createForm]);
 
 	const handleCancelClick = (recordings?: Recording[]) => {
 		if (recordings) setRecordings(recordings);

From eeddcb4d0404455d5b21fed17ad0c6c523c37074 Mon Sep 17 00:00:00 2001
From: nicolaschapur <nicolaschapur@sirius.com.ar>
Date: Fri, 14 Jun 2024 13:13:31 -0300
Subject: [PATCH 3/6] [NC]: Adds dependency fix

---
 apps/mocksi-lite/content/Popup/CreateDemo/index.tsx | 1 +
 1 file changed, 1 insertion(+)

diff --git a/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx b/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
index 1a531dc7..f13d2542 100644
--- a/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
+++ b/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
@@ -29,6 +29,7 @@ const CreateDemo = ({
 		}
 	};
 
+  // biome-ignore
 	useEffect(() => {
 		if (!createForm) {
 			getRecordings();

From 0a457b98421c54be8de642a6b396791ebccb330e Mon Sep 17 00:00:00 2001
From: nicolaschapur <nicolaschapur@sirius.com.ar>
Date: Fri, 14 Jun 2024 13:14:59 -0300
Subject: [PATCH 4/6] [NC]: Adds dependency fix

---
 apps/mocksi-lite/content/Popup/CreateDemo/index.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx b/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
index f13d2542..9ba68662 100644
--- a/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
+++ b/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
@@ -29,7 +29,7 @@ const CreateDemo = ({
 		}
 	};
 
-  // biome-ignore
+	// biome-ignore lint/correctness/useExhaustiveDependencies:
 	useEffect(() => {
 		if (!createForm) {
 			getRecordings();

From 2a8d3d261687786c2da2b51e91996b26f12fb270 Mon Sep 17 00:00:00 2001
From: nicolaschapur <nicolaschapur@sirius.com.ar>
Date: Fri, 14 Jun 2024 14:24:14 -0300
Subject: [PATCH 5/6] [NC]: correct error handling

---
 .../content/Popup/CreateDemo/index.tsx           | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx b/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
index 9ba68662..f8c8a805 100644
--- a/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
+++ b/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
@@ -20,12 +20,16 @@ const CreateDemo = ({
 	const [recordings, setRecordings] = useState<Recording[]>([]);
 
 	const getRecordings = async () => {
-		const results = await chrome.storage.local.get(["recordings"]);
-		const newRecordings = JSON.parse(results.recordings);
-		if (newRecordings.length === recordings.length) {
-			getRecordings();
-		} else {
-			setRecordings(newRecordings);
+		try {
+			const results = await chrome.storage.local.get(["recordings"]);
+			const newRecordings = JSON.parse(results.recordings ?? "{}");
+			if (newRecordings.length === recordings.length) {
+				getRecordings();
+			} else {
+				setRecordings(newRecordings);
+			}
+		} catch (error) {
+			return;
 		}
 	};
 

From 6b371657fcf628be8ebe330bb96d796b1ddfa3ee Mon Sep 17 00:00:00 2001
From: nicolaschapur <nicolaschapur@sirius.com.ar>
Date: Mon, 17 Jun 2024 13:55:36 -0300
Subject: [PATCH 6/6] [NC]: biome fixes

---
 .../content/Popup/CreateDemo/index.tsx        | 32 +++++++++----------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx b/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
index b837c2bf..08f5144b 100644
--- a/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
+++ b/apps/mocksi-lite/content/Popup/CreateDemo/index.tsx
@@ -19,22 +19,22 @@ const CreateDemo = ({
 }: CreateDemoProps) => {
 	const [recordings, setRecordings] = useState<Recording[]>([]);
 
-  const getRecordings = async () => {
-    let continueFetching = true;
-    while (continueFetching) {
-      try {
-        const results = await chrome.storage.local.get(["recordings"]);
-        const newRecordings = JSON.parse(results.recordings ?? "{}");
-        if (newRecordings.length !== recordings.length) {
-          setRecordings(newRecordings);
-          continueFetching = false; // Stop the loop if recordings have been updated
-        }
-      } catch (error) {
-        continueFetching = false; // Stop the loop in case of an error
-        console.error("Failed to fetch recordings:", error);
-      }
-    }
-  };
+	const getRecordings = async () => {
+		let continueFetching = true;
+		while (continueFetching) {
+			try {
+				const results = await chrome.storage.local.get(["recordings"]);
+				const newRecordings = JSON.parse(results.recordings ?? "{}");
+				if (newRecordings.length !== recordings.length) {
+					setRecordings(newRecordings);
+					continueFetching = false; // Stop the loop if recordings have been updated
+				}
+			} catch (error) {
+				continueFetching = false; // Stop the loop in case of an error
+				console.error("Failed to fetch recordings:", error);
+			}
+		}
+	};
 
 	// biome-ignore lint/correctness/useExhaustiveDependencies:
 	useEffect(() => {