Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with "Hot Swap [Fabric]" by "thepeebrain" #184

Open
1 of 3 tasks
SamHammie opened this issue Mar 4, 2024 · 1 comment
Open
1 of 3 tasks

Incompatibility with "Hot Swap [Fabric]" by "thepeebrain" #184

SamHammie opened this issue Mar 4, 2024 · 1 comment
Labels
bug Something isn't working compatibility Related to another mod unverified A new issue that we haven't reproduced.

Comments

@SamHammie
Copy link

SamHammie commented Mar 4, 2024

Description of the issue

When I turn on the freecam mode, the functionality of "Hot Swap [Fabric]" version by "thepeebrain" gets completely disabled, and the only way to fix it is to leave and rejoin the world you're in.

Expected behavior

I expected the functionality of the other mod to continue working.

Steps to reproduce

  1. Join a multiplayer server (I have yet to replicate this in single player)
  2. Enable Freecam by pressing F4
  3. The functionality of the other mod is disabled until you leave and rejoin the server

Log output

View them here.

Crash report

Not applicable.

How prevalent is the issue?

Every time I activate freecam mode after rejoining the world.

Freecam version

1.2.1+1.20

Are you using "Modrinth Edition"?

No

Minecraft version

1.20.1

Modding platform

  • Fabric
  • Neoforge
  • Forge
@SamHammie SamHammie added bug Something isn't working unverified A new issue that we haven't reproduced. labels Mar 4, 2024
@MattSturgeon
Copy link
Member

MattSturgeon commented Mar 4, 2024

Before looking into this properly, my first instinct is that this is probably an issue with Hot Swap rather than Freecam. Thanks for reporting the issue there too.

Looking through their code, this bit where they cache the current player is very suspicious.

I suspect when Freecam "spawns", their cached player becomes the camera (bug), and when Freecam "despawns" their cached player becomes null (bigger bug).

@MattSturgeon MattSturgeon added the compatibility Related to another mod label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility Related to another mod unverified A new issue that we haven't reproduced.
Projects
None yet
Development

No branches or pull requests

2 participants