Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh_covering should provide geohash name as a variable #34

Open
dshkol opened this issue Jun 23, 2020 · 1 comment
Open

gh_covering should provide geohash name as a variable #34

dshkol opened this issue Jun 23, 2020 · 1 comment

Comments

@dshkol
Copy link
Collaborator

dshkol commented Jun 23, 2020

Right now using gh_covering only stores geohash names as the rownames attribute. In practice, I find that everytime I use gh_covering, I follow it up like this:

gh_covering(spatial_object, precision = 4) %>% 
  mutate(gh = rownames(.))

Three possible solutions:

  1. Currently the ID variable returns a numeric index. Can replace this with the geohash name as ID as default behaviour
  2. Keep the ID variable and add a gh variable with the name as default behaviour
  3. Do 1/2 if specified with an argument, e.g. labelled = TRUE in the function call
@dshkol
Copy link
Collaborator Author

dshkol commented Nov 2, 2020

Just came here to open this exact same issue 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant