Add disabled states to all input components #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
7 tasks
david0xd
force-pushed
the
dd/add-disabled-states
branch
from
9a3d1a6 to
06893f3
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3030 +/- ##
=======================================
Coverage 94.80% 94.80%
=======================================
Files 503 503
Lines 10996 10996
Branches 1685 1685
=======================================
Hits 10425 10425
Misses 571 571 ☔ View full report in Codecov by Sentry. |
david0xd
force-pushed
the
dd/add-disabled-states
branch
from
0471a57 to
a2ec7ba
Compare
FrederikBolding
approved these changes
Jan 28, 2025
david0xd
force-pushed
the
dd/add-disabled-states
branch
from
a2ec7ba to
a2e93c2
Compare
FrederikBolding
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Feb 3, 2025
…9896) ## **Description** This PR integrates new Snaps UI feature for disabling interactive UI components. [](https://codespaces.new/MetaMask/metamask-extension/pull/29896?quickstart=1) ## **Related issues** Fixes: #29669 ## **Related Pull Requests** MetaMask/snaps#3030 ## **Manual testing steps** 1. Make new Snap with custom UI using interactive UI components specified in the task linked under "related issues". 2. Add flag `disabled={true}` to these components. 3. Check that components with `disabled` flag are not clickable and their styling is different (opacity 0.5). ## **Screenshots/Recordings** ### **Before** `disabled` state was not available before, nothing to show here. ### **After**  https://github.com/user-attachments/assets/5c8a0404-a7d6-49f1-8e8d-041daaa3b09b ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/29896?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
disabledstate to all input-related Snaps UI components.Related task: MetaMask/metamask-extension#29669
Extension integration PR: MetaMask/metamask-extension#29896
Screen.Recording.2025-01-24.at.16.53.37.mov