Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Alerts blocks tab navigation #12849

Closed
vinnyhoward opened this issue Jan 7, 2025 · 0 comments · Fixed by #12853
Closed

[Bug]: Alerts blocks tab navigation #12849

vinnyhoward opened this issue Jan 7, 2025 · 0 comments · Fixed by #12853
Assignees
@vinnyhoward
Labels
regression-prod-7.37.1 Regression bug that was found in production in release 7.37.1 release-7.40.0 Issue or pull request that will be included in release 7.40.0 Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-wallet-ux type-bug Something isn't working

Comments

@vinnyhoward
Copy link
Contributor

Describe the bug

We've received several complaints about our Alert component blocking the tab navigation which leads to user frustration

Expected behavior

We should move the Alert banner above the tab navigation and make it easier to dismiss as bonus

Screenshots/Recordings

Image

Steps to reproduce

  1. Switch network
  2. Observe the Alert banner being annoying

Error messages or log output



Detection stage


In production (default)


Version


7.37.1


Build type


Other (please specify exactly where you obtained this build in "Additional Context" section)


Device


All devices


Operating system


Other (please elaborate in the "Additional Context" section)


Additional context


No response


Severity


No response

      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @vinnyhoward
vinnyhoward




            added
      

  team-wallet-ux


      

  type-bug

  Something isn't working

  labels


      Jan 7, 2025

    

  



    

    

      
    

    


      

          @vinnyhoward
vinnyhoward




              self-assigned this


      Jan 7, 2025

    

  



    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by severity


      Jan 7, 2025

    

  



    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by team


      Jan 7, 2025

    

  



    

    

      
    

    


      

          @metamaskbot
metamaskbot




          added
  the 

  regression-prod-7.37.1

  Regression bug that was found in production in release 7.37.1
 label


      Jan 7, 2025

    

  



  

  

    
  


  

      

    @vinnyhoward
vinnyhoward



    mentioned this issue
    
      Jan 7, 2025
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    7 tasks
  





  




    

    

      
    

    


      

          @joaoloureirop
joaoloureirop




          added
  the 

  Sev2-normal

  An issue that may lead to users misunderstanding some limited risks they are taking
 label


      Jan 8, 2025

    

  



  


  
    
  
  

    
  github-merge-queue bot

      pushed a commit
      that referenced
      this issue

    
      Jan 8, 2025
    
    

      


  

    

      


  

      
        @vinnyhoward
  





      

        
          fix(12849): alert toast blocking tab navigation (#12853)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          8dc1c9f
        
      

    

  

    

      
## **Description**

We have received several complaints about our toast blocking our tab
navigation slowing down user experience


## **Related issues**

Fixes:
[#12849](#12849)

## **Manual testing steps**

1. On the wallet home page, click on the network selector on the top
left
2. Click on any network
3. The toast should pop up

## **Screenshots/Recordings**
### Android
| Before  | After |
|:---:|:---:|

|![before](https://github.com/user-attachments/assets/d4d28558-3e94-49ce-8a76-e2a0258d5e21)|![after](https://github.com/user-attachments/assets/e439f189-f4fc-4db9-b167-b17405e35205)|

### iOS
| Before  | After |
|:---:|:---:|

|![before](https://github.com/user-attachments/assets/bb0bb5ad-f5e1-4ffa-82bb-80454f2eb09c)|![after](https://github.com/user-attachments/assets/1ec31b56-2e40-4897-abfd-58fb4a573b69)|

### **Before**

NA

### **After**

NA

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

    




    

  




    

    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this from To be fixed
  to Fixed
  in Bugs by team


      Jan 8, 2025

    

  



    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this from To be fixed
  to Fixed
  in Bugs by severity


      Jan 8, 2025

    

  



    

    

      
    

    


      

          @metamaskbot
metamaskbot




          added
  the 

  release-7.40.0

  Issue or pull request that will be included in release 7.40.0
 label


      Jan 8, 2025

    

  












  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @vinnyhoward
  
    vinnyhoward
    

      








      


  


  

    Labels
  



    

      

    regression-prod-7.37.1

  Regression bug that was found in production in release 7.37.1
  

    release-7.40.0

  Issue or pull request that will be included in release 7.40.0
  

    Sev2-normal

  An issue that may lead to users misunderstanding some limited risks they are taking
  

    team-wallet-ux

  

    type-bug

  Something isn't working








      

  

    

        

    Projects
  


        




        
  

    

      
          
        Bugs by severity
        
    

    

      

          

  

    
      Archived in project



      

    

    

  



        
  

    

      
          
        Bugs by team
        
    

    

      

            
    Status: Fixed

              
      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      fix(12849): alert toast blocking tab navigation

    
      MetaMask/metamask-mobile
    





    
  




      

    

  
      

  

    

      3 participants
    

    

        
          @vinnyhoward 
        
          @metamaskbot 
        
          @joaoloureirop