Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: decoding_in_progress metric and flaky decoding_latency metrics tests #29852

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: decoding_in_progress metric and flaky decoding_latency metrics tests #29852

wants to merge 2 commits into from
+32 −6

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Jan 22, 2025 •
edited
Loading

Description

Fix:

  1. Unreachable decoding_in_progress metric when decoding is loading
  • Add metric when decoding is loading
  1. Flaky decoding_latency metric test
  • Add faker timer

Open in GitHub Codespaces

Related issues

Fixes: #29851
Fixes: #29509

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Flaky test appearing locally:
CleanShot 2025-01-21 at 17 38 18@2x

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner January 22, 2025 15:26
@digiwand digiwand added the team-confirmations Push issues to confirmations team label Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand changed the title fix: decoding_in_progress metric and flaky decoding metrics tests fix: decoding_in_progress metric and flaky decoding_latency metrics tests Jan 22, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [3b191a2]
Page Load Metrics (1729 ± 82 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15132087173917082
domContentLoaded14742074170816378
load14792086172917082
domInteractive278339178
backgroundConnect65423157
firstReactRender1796372612
getState465242210
initialActions01000
loadScripts10301600126216278
setupStore75915168
uiStartup168124542048232111
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -128.94 KiB (-2.17%)
  • ui: 47 Bytes (0.00%)
  • common: -313.67 KiB (-3.59%)

@mikesposito
Copy link
Member

mikesposito commented Jan 22, 2025 •
edited
Loading

Something is off with the calculated bundle size diff from the bot:

Bundle size diffs [🚀 Bundle size reduced!]
  • background: -128.94 KiB (-2.17%)
  • ui: 47 Bytes (0.00%)
  • common: -313.67 KiB (-3.59%)

The numbers seem completely made up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
3 participants
@digiwand @metamaskbot @mikesposito