Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useExternalServices check for isDecodeSignatureRequestEnabled #29847

Closed
9 tasks
digiwand opened this issue Jan 22, 2025 · 0 comments · Fixed by #29939 · May be fixed by #29909
Closed
9 tasks

Remove useExternalServices check for isDecodeSignatureRequestEnabled #29847

digiwand opened this issue Jan 22, 2025 · 0 comments · Fixed by #29939 · May be fixed by #29909
Assignees
@pnarayanaswamy
Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-confirmations Push issues to confirmations team

Comments

@digiwand
Copy link
Contributor

What is this about?

Based on discussion, since the decoder API is an internal service that doesn't send data to any external services, we can remove the useExternalServices check.

decoderAPI should only check useTransactionSimulations

In metamask-controller,

      isDecodeSignatureRequestEnabled: () =>
        this.preferencesController.state.useExternalServices === true &&
        this.preferencesController.state.useTransactionSimulations,

→

      isDecodeSignatureRequestEnabled: () =>
        this.preferencesController.state.useTransactionSimulations,

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@digiwand digiwand added the team-confirmations Push issues to confirmations team label Jan 22, 2025
@digiwand digiwand mentioned this issue Jan 22, 2025
Closed
9 tasks
rounakkraaj-1744 added a commit to rounakkraaj-1744/metamask-extension-forked that referenced this issue Jan 26, 2025
@rounakkraaj-1744
Issue MetaMask#29847: Removed and edited the code for useExternalServ…
109f5d3 
…ices check for isDecodeSignatureRequestEnabled
@rounakkraaj-1744 rounakkraaj-1744 mentioned this issue Jan 26, 2025
Open
@pnarayanaswamy pnarayanaswamy self-assigned this Jan 28, 2025
@pnarayanaswamy pnarayanaswamy mentioned this issue Jan 28, 2025
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 28, 2025
@pnarayanaswamy
chore: Remove useExternalServices check for isDecodeSignatureRequestE… (
250b595 
#29939)

…nabled


<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29939?quickstart=1)

## **Related issues**

Fixes:
[#29847](#29847)

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnarayanaswamy pnarayanaswamy

Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
3 participants
@digiwand @pnarayanaswamy @metamaskbot