Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Nonce customization is not disabled for Smart transactions #29841

Open
sleepytanya opened this issue Jan 22, 2025 · 0 comments
Open

[Bug]: Nonce customization is not disabled for Smart transactions #29841

sleepytanya opened this issue Jan 22, 2025 · 0 comments
Labels
regression-RC-12.11.0 Regression bug that was found in release candidate (RC) for release 12.11.0 release-blocker This bug is blocking the next release Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-transactions Transactions team type-bug

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Jan 22, 2025

Describe the bug

Nonce customization is not disabled for Smart transactions. Transaction with modified nonce can be created but eventually fails with Transaction does not have a transaction hash, there was a problem error

Expected behavior

Custom nonce should be disabled for STX

Screenshots/Recordings

Image

Screen.Recording.2025-01-21.at.22.07.57.mov
Image

Steps to reproduce

  1. Connect to mainnet
  2. Disable Settings->Advanced->Customize transaction nonce
  3. Enable Settings->Advanced->Smart Transactions
  4. Start Send transaction

Error messages or log output

Error in smart transaction publish hook Error: Transaction does not have a transaction hash, there was a problem
    at SmartTransactionHook.submit (js-scripts_b.ea45fab…e8ba95f.js:12227:23)
    at async js-node_modules_metamask_r.531e1f8d4eae141ff1c7.js:56434:46
    at async TransactionController.approveTransaction (js-node_modules_metamask_r.531e1f8d4eae141ff1c7.js:56430:13)
    at async TransactionController.processApproval (js-node_modules_metamask_r.531e1f8d4eae141ff1c7.js:56320:44)

Detection stage

In production (default)

Version

v12.11.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added regression-RC-12.11.0 Regression bug that was found in release candidate (RC) for release 12.11.0 release-blocker This bug is blocking the next release Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-transactions Transactions team type-bug labels Jan 22, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 22, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC-12.11.0 Regression bug that was found in release candidate (RC) for release 12.11.0 release-blocker This bug is blocking the next release Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-transactions Transactions team type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

1 participant