Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: browser-wide crash #29821

Open
mchmatt opened this issue Jan 21, 2025 · 4 comments
Open

[Bug]: browser-wide crash #29821

mchmatt opened this issue Jan 21, 2025 · 4 comments
Assignees
Labels
external-contributor Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-extension-platform type-bug

Comments

@mchmatt
Copy link

mchmatt commented Jan 21, 2025

Describe the bug

Do not try this if you have important stuff open. This will crash all tabs and profiles, not just the one tab you're testing with.

Notes

This can be triggered programmatically by doing window.open("<url>", "_blank");

Expected behavior

No response

Screenshots/Recordings

No response

Steps to reproduce

  1. Install MetaMask and set up a wallet
  2. Open chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/notification.html or moz-extension://a0b28803-be23-4c3d-81d2-9735449f7d26/notification.html as a new tab

Error messages or log output

Detection stage

In production (default)

Version

12.10.1

Build type

None

Browser

Chrome, Firefox

Operating system

Windows, MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jan 21, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 21, 2025
@metamaskbot metamaskbot added external-contributor regression-prod-12.9.3 Regression bug that was found in production in release 12.9.3 regression-prod-12.10.1 Regression bug that was found in production in release 12.10.1 and removed regression-prod-12.9.3 Regression bug that was found in production in release 12.9.3 labels Jan 21, 2025
@mchmatt
Copy link
Author

mchmatt commented Jan 21, 2025

Also happens in 12.10.1 (latest in Chrome store); having Notifications disabled or enabled doesn't seem to matter

@DanielTech21 DanielTech21 added the Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. label Jan 21, 2025
@DanielTech21
Copy link

Hi @mchmatt
Thanks for reporting this to us.

It has been assigned to the relevant product team to investigate this further.

@dbrans
Copy link
Contributor

dbrans commented Jan 22, 2025

This is a pretty annoying UX issue: if someone accidentally opens notification.html in a regular tab, it triggers a window-close behavior that can create a frustrating loop.

The tricky part is when Chrome is set to restore previous sessions – you can get stuck in a situation where the profile keeps closing itself because notification.html auto-closes the window.

I think this happens because notification.html is designed to close itself when there's nothing to confirm, but it shouldn't close the entire window when opened directly.

For anyone running into this: you can work around it by opening settings (CMD-,) and using "close other tabs" to break the loop.

Looping in @Gudahtt and @danjm for visibility

@dbrans
Copy link
Contributor

dbrans commented Jan 22, 2025

Removing rollout-blocker since this is reproducible in 12.9.3.

@dbrans dbrans removed rollout-blocker regression-prod-12.10.1 Regression bug that was found in production in release 12.10.1 labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-extension-platform type-bug
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

5 participants