Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Upgrade hw-app-eth library to v6.42.0 for Ledger Clear Signing #29813

Open
vivek-consensys opened this issue Jan 21, 2025 · 1 comment · May be fixed by #29820
Open

[Bug] Upgrade hw-app-eth library to v6.42.0 for Ledger Clear Signing #29813

vivek-consensys opened this issue Jan 21, 2025 · 1 comment · May be fixed by #29820
Assignees
@dawnseeker8
Labels
hardware-ledger INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-hardware-wallets type-bug

Comments

@vivek-consensys
Copy link

vivek-consensys commented Jan 21, 2025 •
edited
Loading

  • Without 6.42.0, when EIP-712 content is not sorted as defined in solidity struct “types” , the user can be blocked.
  • Without 6.41.0, for some legacy transaction (type 0), the v signature can be wrong and the transaction won’t be broadcasted

Thread: https://consensys.slack.com/archives/C02CYKAA8G1/p1737381638976519?thread_ts=1737106010.543919&cid=C02CYKAA8G1
@vivek-consensys vivek-consensys added hardware-ledger Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-hardware-wallets type-bug labels Jan 21, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 21, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jan 21, 2025
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Jan 21, 2025
@dawnseeker8
Copy link
Contributor

PR has been created in account repo . MetaMask/accounts#153

will upgrade in extension repo after above PR release.

@dawnseeker8 dawnseeker8 linked a pull request Jan 21, 2025 that will close this issue
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dawnseeker8 dawnseeker8

Labels
hardware-ledger INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-hardware-wallets type-bug
Projects
Bugs by severity
Status: To be fixed
Bugs by team
Status: To be fixed
Milestone
No milestone
3 participants
@dawnseeker8 @metamaskbot @vivek-consensys