Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UMDP3 checker linting issues #53

Open
t00sa opened this issue Jan 13, 2025 · 2 comments
Open

Fix UMDP3 checker linting issues #53

t00sa opened this issue Jan 13, 2025 · 2 comments
Assignees
@t00sa

Comments

@t00sa
Copy link
Contributor

t00sa commented Jan 13, 2025

Linting has thrown up the following problems with the UMDP3 checker code:

  /github/workspace/script_umdp3_checker/bin/UMDP3.pm source OK
  /github/workspace/script_umdp3_checker/bin/UMDP3CriticPolicy.pm source OK
  /github/workspace/script_umdp3_checker/bin/UMDP3DispatchTables.pm source OK
  /github/workspace/script_umdp3_checker/bin/umdp3_check.pl: Subroutine "new" called using indirect syntax at line 1013, column 28.  See page 349 of PBP.  (Severity: 5)
  /github/workspace/script_umdp3_checker/bin/umdp3_check.pl: Subroutine "new" called using indirect syntax at line 1013, column 28.  See page 349 of PBP.  (Severity: 5)
  /github/workspace/script_umdp3_checker/bin/umdp3_check.pl: Subroutine "new" called using indirect syntax at line 1019, column 29.  See page 349 of PBP.  (Severity: 5)
  /github/workspace/script_umdp3_checker/bin/umdp3_check.pl: Subroutine "new" called using indirect syntax at line 1019, column 29.  See page 349 of PBP.  (Severity: 5)
  /github/workspace/script_umdp3_checker/bin/umdp3_check.pl: Bareword file handle opened at line 1136, column 31.  See pages 202,204 of PBP.  (Severity: 5)

These should probably be resolved.
@t00sa t00sa self-assigned this Jan 13, 2025
@t00sa
Copy link
Contributor Author

t00sa commented Jan 13, 2025

Also fix other linting problems as part of this issue

@t00sa
Copy link
Contributor Author

t00sa commented Jan 14, 2025

James has OKed the changes to the shell scripts, so this can be added to the linting PR.

@yaswant yaswant mentioned this issue Jan 24, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t00sa t00sa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

53-fix-umdp3-checker-linting-issues MetOffice/SimSys_Scripts
1 participant
@t00sa