Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in line 132 of calc_seq_p #33

Closed
LittleBeannie opened this issue Jan 30, 2024 · 0 comments · Fixed by #34
Closed

Bug in line 132 of calc_seq_p #33

LittleBeannie opened this issue Jan 30, 2024 · 0 comments · Fixed by #34
Assignees
@LittleBeannie
Labels
bug Something isn't working

Comments

@LittleBeannie
Copy link
Collaborator

LittleBeannie commented Jan 30, 2024 •
edited
Loading

If total analysis = 3, and the test analysis = 2, the line 132 breaks.
Both p_obs and ans should filter analysis <= test_analysis.

wpgsd/R/calc_seq_p.R

Line 132 in 6ec4027

p_diff_new <- p_obs[[hhh]] - ans[[hhh]]

@LittleBeannie LittleBeannie added the bug Something isn't working label Jan 30, 2024
@LittleBeannie LittleBeannie self-assigned this Jan 30, 2024
@LittleBeannie LittleBeannie linked a pull request Jan 31, 2024 that will close this issue
fix the bug on p_obs #34
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LittleBeannie LittleBeannie

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix the bug on p_obs Merck/wpgsd
1 participant
@LittleBeannie