Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compat: Silver Birch Item Shelf fails to generate model. #30

Open
VoidLeech opened this issue Dec 5, 2024 · 1 comment · May be fixed by #31
Open

Compat: Silver Birch Item Shelf fails to generate model. #30

VoidLeech opened this issue Dec 5, 2024 · 1 comment · May be fixed by #31

Comments

@VoidLeech
Copy link

VoidLeech commented Dec 5, 2024 •
edited
Loading

When used in conjunction with Silver Birch, there is no block or item model for the Silver Birch Item Shelf:
2024-12-05_19 08 19

This is despite the fact Silver Birch should be detected as a wood type: proper models are generated for the Supplementaries sign post as well as when using EveryCompat and a supported mod.
Edit: the item shelves for other wood types generate fine.

Versions:
Forge 47.3.0
Supplementaries 3.1.10
Supplementaries Squared 1.1.18
Silver Birch 1.1.1 (same with the later released V2 that also has version number 1.1.1)

Logs:
Debug: https://mclo.gs/aem6H9i
Latest: https://mclo.gs/3XhxwtU
@VoidLeech
Copy link
Author

Probably caused by use of 'birch' here:

supp_squared/common/src/main/java/net/mehvahdjukaar/suppsquared/client/ClientPackProvider.java

Lines 48 to 71 in dc6676e

public void regenerateDynamicAssets(ResourceManager manager) {
//------item shelves-----
StaticResource isItemModel = StaticResource.getOrLog(manager,
ResType.ITEM_MODELS.getPath(SuppSquared.res("item_shelf_birch")));
StaticResource isBlockState = StaticResource.getOrLog(manager,
ResType.BLOCKSTATES.getPath(SuppSquared.res("item_shelf_birch")));
StaticResource isModel = StaticResource.getOrLog(manager,
ResType.BLOCK_MODELS.getPath(SuppSquared.res("item_shelves/birch")));
SuppSquared.ITEM_SHELVES.forEach((wood, sign) -> {
String id = Utils.getID(sign).getPath();
if (wood == WoodTypeRegistry.OAK_TYPE) return;
try {
addSimilarJsonResource(manager, isBlockState, s ->
s.replace("item_shelf_birch", id)
.replace("birch", id.replace("item_shelf_", "")));
addSimilarJsonResource(manager, isModel, s ->
s.replace("item_shelf_birch", id)
.replace("birch", id.replace("item_shelf_", "")));
addSimilarJsonResource(manager, isItemModel, s ->
s.replace("item_shelf_birch", id)
.replace("birch", id.replace("item_shelf_", "")));

@VoidLeech VoidLeech linked a pull request Dec 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Wood types with birch in the name not generating shelf model VoidLeech/supp_squared
1 participant
@VoidLeech