Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuring the code to support proper versioning. #78

Open
StevenAlexanderJohnson opened this issue Dec 2, 2023 · 1 comment
Open
Labels

Comments

@StevenAlexanderJohnson
Copy link

I'm noticing in the Web portion of this repo that the versioning is being handled by adding "v1" to the URL.
It is possible to create a router containing all v1 routes in a module then use that module as a "nest" router.
This refactor would allow to scale the API with new versions easier, as once you sunset a version you can edit the v2 module without risk of editing the v1 code.

It would be a decent refactor so I'll wait for feedback on when this refactor should take place as to not create merge conflicts.

@Bash-09
Copy link
Contributor

Bash-09 commented Jan 9, 2024

This would be a totally reasonable change to make, any poor design decision on the web API side of things was probably me not knowing much about what I'm doing in that area lol.

I think it's probably not hugely consequential, but I wouldn't be opposed to such a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants