-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Like activity ID is not dereferencable #772
Comments
You are absoultely right and it is the case for all activities that we generate. We do not have the activities saved in the DB and I do not know what a good way to save those would be. If we just save the json it will take up a lot of space, but would be easy to implement. If we'd save the referenced actor and object and payload etc it would take up less space, but would need a lot of logic to be implemented properly |
Perhaps you can generate activities on the fly, when they are requested? |
@e-five256 @nobodyatroot @melroy89 @asdfzdfj what do you think? I don't know if I'd want to delete activities again... But to save DB space it might be unavoidable... |
imo a mix of both is probably needed, if you really want this for the kind of activity that creates stuff e.g. for the kind of activity that negates/removes stuff e.g. |
This issue is stale because it has been open 50 days with no activity. Remove stale label or comment or this will be closed in 6 days. |
Still relevant. I solved a similar problem in my own software by caching all outgoing activities (they are automatically removed after several days). |
It's still on my radar, but I don't want to implement a temporary fix, I want to solve it properly but that takes time. I have a lot of items I am currently working on, but this is not yet on that list. You should be able to see the dashboard with things we are working on here: https://github.com/orgs/MbinOrg/projects/5/views/1 (note: atm not a lot of us use the board, but I do) |
Sure, this is not urgent. I just wanted to prevent stale bot from closing the issue |
fyi, we neutered stale bot from closing any issues. it'll say it's going to close it in x number of days, but not anymore. we don't have anyone dedicated to working on Mbin full-time, so it can be a slow process at times with work/personal schedules taking priority. |
Describe the bug
Like
activities have IDs, but these IDs can not be dereferenced. Mbin server returns an empty JSON object.On which Mbin instance did you find the bug?
https://moist.catsweat.com and others
Which Mbin version was running on the instance?
1.5.3
To Reproduce
Expected behavior
Server should return the entire Like activity.
Additional context
When I receive an
Announce(X)
activity in my inbox, I want to verify thatX
activity is real and the group actor didn't make it up. IfAnnounce.actor
andX.actor
belong to the same server, I can assume that activity is valid. However, when actors are on different servers, I need to verify the authenticity ofX
activity by fetching it from the server of origin. Otherwise the server of the group actor could impersonate actors on other servers.You might not consider it a security risk, but I would appreciate if you make activity IDs dereferencable.
Currently I'm working only with announced
Like
activities, but other activities such asCreate
andDelete
may also have this problem - I haven't verified that.The text was updated successfully, but these errors were encountered: