Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script for move-to-framework with history #57

Open
mpg opened this issue Oct 10, 2024 · 3 comments
Open

Script for move-to-framework with history #57

mpg opened this issue Oct 10, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request size-s Estimated task size: small (~2d)

Comments

@mpg
Copy link
Contributor

mpg commented Oct 10, 2024

As pointed out by Gilles, the script for moving files to the framework repo while preserving their history is going to be an essential maintainer tool for the next few month, so it would make sense to make it more robust and easy to use (and possibly have it in the framework repo).

@mpg mpg added the enhancement New feature or request label Oct 10, 2024
@mpg mpg moved this to Framework 1/3 (MVP repo split) in Mbed TLS Epics Oct 10, 2024
@davidhorstmann-arm
Copy link
Contributor

Estimating < 1 ideal day, around 3 actual days for this, so adding size-s

@davidhorstmann-arm davidhorstmann-arm added the size-s Estimated task size: small (~2d) label Oct 10, 2024
@mpg
Copy link
Contributor Author

mpg commented Jan 7, 2025

Github doesn't let me properly link the PR, but this is Mbed-TLS/mbedtls-docs#145

For the record, the script as it stands has been used successfully a number of times, so there was a consensus on merging that PR quickly, and addressing any leftover comments in a follow-up - it makes little sense to keep the PR unmerged while we're already actively using the script.

@bensze01 I think you said you'd review it?

@gilles-peskine-arm
Copy link
Contributor

@mpg I believe Harry was going to use the script to rewrite #114. @Harry-Ramsey, if you use the script from Mbed-TLS/mbedtls-docs#145 and you're ok with it, would you mind approving Mbed-TLS/mbedtls-docs#145 ? In the mbedtls-docs repository, the standard for approving is “meets basic expectations, not harmful”, a lot weaker than in our other repositories. So if you've successfully used the script, that's probably good enough for approving.

(I earlier requested changes on Mbed-TLS/mbedtls-docs#145 because the version at the time didn't work for me. David has since then fixed the problem I ran into, but I haven't had a chance to use the new version, so I dismissed my earlier review but I don't feel comfortable approving the new version.)

@mpg mpg moved this from Framework 1/3 (MVP repo split) to TF-PSA-Crypto all.sh components in Mbed TLS Epics Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size-s Estimated task size: small (~2d)
Projects
Status: TF-PSA-Crypto all.sh components
Development

No branches or pull requests

3 participants