Run TF-PSA-Crypto components without cloning Mbed TLS #190
Conversation
Signed-off-by: Bence Szépkúti <[email protected]>
Signed-off-by: Bence Szépkúti <[email protected]>
Signed-off-by: Bence Szépkúti <[email protected]>
Signed-off-by: Bence Szépkúti <[email protected]>
bensze01
added
enhancement
| ), | ||
| returnStdout: true | ||
| ).trim().split('\n') | ||
| echo "All all.sh components: ${all.join(" ")}" |
There was a problem hiding this comment.
Minor should probably adjust the message as well: All all.sh -> all.sh?
| @@ -245,7 +245,7 @@ echo >&2 'Note: "clang" will run /usr/bin/clang -Wno-error=c11-extensions' | |||
| ''' | |||
| } | |||
|
|
|||
| if (info.has_min_requirements) { | |||
| if (repo == 'tls' && info.has_min_requirements) { | |||
There was a problem hiding this comment.
I'm not sure I understand why we need the repo == 'tls' part: currently tf-psa-crypto doesn't have scripts/min_requirements.py but I'd guess info.has_min_requirements should reflect that?
There was a problem hiding this comment.
Also, it seems to me we'll need to get scripts/min_requirements.py (and supporting files) in tf-psa-crypto (or the framework) before moving python scripts that have requirements beyond what happens to be already installed by apt. @ronald-cron-arm not sure if that dependency was already on your radar?
There was a problem hiding this comment.
No that was not on my radar. I can see that @valeriosetti has started working on Mbed-TLS/mbedtls-framework#86. Does this issue fully cover the dependency?
There was a problem hiding this comment.
I can see that @valeriosetti has started working on Mbed-TLS/mbedtls-framework#86.
Yes, PRs Mbed-TLS/mbedtls-framework#105 and related ones (Mbed-TLS/mbedtls#9863 Mbed-TLS/mbedtls#9864) are ready for review. There's only the usual framework confict on development and mbedtls-3.6, but that can easily be fixed once Mbed-TLS/mbedtls-framework#105 is merged.
| break | ||
| default: | ||
| error("Invalid repo: $repo") | ||
| } | ||
| checkout_repo.checkout_tls_repo(info) |
There was a problem hiding this comment.
Don't you mean to remove this line?
| @@ -668,6 +678,12 @@ def gen_release_jobs(BranchInfo info, String label_prefix='', boolean run_exampl | |||
| } | |||
| } | |||
|
|
|||
| if (env.RUN_TF_PSA_CRYPTO_ALL_SH == "true") { | |||
| info.tf_psa_crypto_all_sh_components.each({ component, platform -> | |||
| jobs = jobs + gen_all_sh_jobs(info, platform, component, label_prefix) | |||
There was a problem hiding this comment.
Shouldn't we pass 'tf-psa-crypto' as the last argument? Otherwise it will default to 'tls'.
Fixes Mbed-TLS/TF-PSA-Crypto#116
Test runs: TBD