Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Detailed Forecast with retry #225

Open
kamiyo opened this issue Aug 16, 2024 · 2 comments
Open

Question: Detailed Forecast with retry #225

kamiyo opened this issue Aug 16, 2024 · 2 comments

Comments

@kamiyo
Copy link
Contributor

kamiyo commented Aug 16, 2024

Is there a reason I'm missing why this can't just raise a NwsNoDataError like the other update functions?

`raise_no_data`currently can only be set to `False`.
"""
if raise_no_data:
raise NotImplementedError(
"raise_no_data=True not implemented for update_detailed_forecast"
)

@MatthewFlamm
Copy link
Owner

My memory is that this was mainly done to keep the changes smaller in the original PR. But likely it only needs a few lines to implement, although I haven't looked closely.

@kamiyo
Copy link
Contributor Author

kamiyo commented Aug 16, 2024

Ok, cool. I was thinking to add the detailed forecast to hass, using the retry wrapper FX. I'll take a stab at it.

While I have you, do you think it's ok to export the Details enum, to work better with intelligence/auto complete when getting detailed forecast, instead of using plain strings?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants