-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending the list of standard response formats (i.e. CIF, POSCAR) #343
Comments
I think this is a very nice idea, and very much in line with what I imagine Edit: upon re-reading what you wrote after having formulated by reply, I realize that you are basically asking whether To actually include May I suggest that you start with creating a Then, at some future point, you'll come to OPTIMADE with your design and propose to adopt it as the standard for |
I also think that it is a very nice idea... It might be worth looking at some previous work by @merkys (https://github.com/cod-developers/CIF2JSON) |
I am mostly interested in standardizing OPTIMADE methods to access other resource representations, such as CIF and POSCAR for Standardizing CIF is a tedious task on its own. COD contains CIF files from more than 43 sources, and we leave the standardization (more like interpretation) to the client, because standardization usually means making assumptions about data, and care should be taken not to overinterpret or invent any data. Of course, conservative inferences and standardizations may be applied, but I would better leave them to the client. There are a lot of tools preparing CIF files for inputs to QM and other calculations. I would prefer implementations providing CIF files in any way that is compatible with already existing CIF standard. CIF2JSON would maybe be useful for representing CIF in JSON (something like |
As said before, I have conflated alternative OPTIMADE response formats and file representations of OPTIMADE entries into a single issue. Now as #360 is merged, I am closing this issue. |
There have been discussions about exposing CIF data (#329) or any entry-related files (#211) through OPTIMADE. Now I remembered the provision of endpoint-specific
response_format
which could be used to ask for specific representations of entries or their collections. Up to now OPTIMADE only supportsjson
response format. I suggest standardizing other optional response formats that could be used by clients to retrieve representations of entries, and my immediate suggestions would be CIF (cif
, native structure data format for the COD) and POSCAR (poscar
). Upon request forresponse_format=cif
client would receive plain CIF file for an entry (or several entries) and could directly use it in calculations etc.It may also be true that I misunderstood the intention of
response_format
. Maybe it is supposed to specify a carrier format for OPTIMADE data. Then foreseen additions to existingjson
would bexml
andyaml
, which would carry the same property information wrapped in their specific syntax. If this is the case, then #211 is worth pursuing to provide other representations of entries instead.The text was updated successfully, but these errors were encountered: