[adapter] use an unconsolidated snapshot in table bootstrapping #31314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pared down version of #31300
When the Coordinator starts we bootstrap tables by first retracting their entire contents so we have a clean slate, and then re-emitting all of the updates. We've seen in some recent releases large memory spikes on Coordinator startup related to creating a consolidated snapshot, and I believe it's this table bootstrapping that is causing the issue.
We don't need a consolidated snapshot to retract the contents, thus this API uses Persist's
snapshot_and_stream
API which should use a smaller bound of memory, specifically it keeps onePart
in memory at a time, and parts are capped at approximately 128MiB.Motivation
Fix memory spike in
envd
startupChecklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.