New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in php 8.1 #225

Open

mikeborisov78 opened this issue Jan 27, 2023 · 1 comment

mikeborisov78 commented Jan 27, 2023

src/HTML5/Parser/UTF8Utils.php

$data = mb_convert_encoding($data, 'UTF-8', $encoding);

error if $data is null in PHP 8.1
help this:

$data = mb_convert_encoding($data.'', 'UTF-8', $encoding);

Contributor

stof commented Jan 30, 2023 •

edited

Loading

The phpdoc on the method declares the contract as @param string $data. So you should only pass a string.

Btw, this won't trigger an error on PHP 8.1 but only a deprecation warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment