Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance Between Motors Calculations Uses Hardcoded 6.35 mm #763

Open
madgrizzle opened this issue Aug 28, 2018 · 8 comments
Open

Distance Between Motors Calculations Uses Hardcoded 6.35 mm #763

madgrizzle opened this issue Aug 28, 2018 · 8 comments

Comments

@madgrizzle
Copy link
Contributor

For those that use different size chains or different sprockets, the distance between motor measurements will be off. The routine currently subtracts a total of 12.7 mm (2x6.35 mm) to account for the two links that are wrapped around the right sprocket. If the chain pitch is different and/or a different number of links are wrapped around the sprocket based upon the number of teeth on the sprocket, this calculation will be off.

@blurfl
Copy link
Collaborator

blurfl commented Aug 28, 2018

It looks like both measureOneChain.py and measureDistBetweenMotors.py do this. Perhaps they should be using chainPitch from the Advanced Settings as triangularCalibration.py does.

chainPitch = float(self.data.config.get('Advanced Settings', 'chainPitch'))

@madgrizzle
Copy link
Contributor Author

But how to deal with different number of teeth on the sprocket.. that's the challenge... unless you force the user to only wrap two links.

@blurfl
Copy link
Collaborator

blurfl commented Aug 28, 2018

Are you using a sprocket with more teeth, having trouble with two links coming adrift?

@BarbourSmith
Copy link
Member

Great catch @madgrizzle!!

I think we are safe to assume only two links because that is what the directions say to do, but we should be using proper pitch computations

@davidelang
Copy link
Contributor

davidelang commented Aug 29, 2018 via email

@madgrizzle
Copy link
Contributor Author

I suspect if you are using a high tooth count sprockets, you'll need to clamp the chain to the sprocket to keep it from coming off. Small price for those to pay to keep the method simple.

@BarbourSmith
Copy link
Member

Small price for those to pay to keep the method simple.

I couldn't agree more. Let's keep it simple

@davidelang
Copy link
Contributor

davidelang commented Aug 29, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants