Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix voxels on linux firefox #4756

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Fix voxels on linux firefox #4756

merged 2 commits into from
Jan 27, 2025

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Jan 26, 2025

Description

With firefox on linux voxels() refuses to render. (Also affects Pluto, at least when opened with firefox) This is caused by the per-instance dummy data of voxels not being used in the shader.

I don't remember what exactly I tested before, but when I originally implemented this just fetching the per-instance data was enough. And it is in vscode and in chrome, but not in firefox.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

Benchmark Results

SHA: 5d2bf4bd6f0540173cea66ac805760aeddea892e

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@ffreyer ffreyer merged commit 53a71a1 into master Jan 27, 2025
22 checks passed
@ffreyer ffreyer deleted the ff/fix-voxels branch January 27, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

2 participants