RPRMakie errors in render_rpr

[rafaqz]

• what version of Makie are you running? (]st -m Makie) 0.21.18
• can you reproduce the bug with a fresh environment ? (]activate --temp; add Makie)
• What platform + GPU are you on? windows intel iris

The lookat field accessed here doesn't seem to exist:

Makie.jl/RPRMakie/src/scene.jl

Line 6 in d6fdf25

l, u, p, fov = c.lookat[], c.upvector[], c.eyeposition[], c.fov[]

This is using the RPR example in the Tyler docs

ERROR: type PixelCamera has no field lookat
Stacktrace:
  [1] getproperty
    @ .\Base.jl:49 [inlined]
  [2] update_rpr_camera!(oldvals::@NamedTuple{}, camera::RadeonProRender.Camera{…}, cam_controls::Makie.PixelCamera, cam::Camera)
    @ RPRMakie C:\Users\rafael.schouten\.julia\packages\RPRMakie\g1jlP\src\scene.jl:6
  [3] display(screen::RPRMakie.Screen, scene::Scene; display_kw::@Kwargs{})
    @ RPRMakie C:\Users\rafael.schouten\.julia\packages\RPRMakie\g1jlP\src\scene.jl:341
  [4] display
    @ C:\Users\rafael.schouten\.julia\packages\RPRMakie\g1jlP\src\scene.jl:333 [inlined]
  [5] colorbuffer(screen::RPRMakie.Screen)
    @ RPRMakie C:\Users\rafael.schouten\.julia\packages\RPRMakie\g1jlP\src\scene.jl:323
  [6] backend_show(screen::RPRMakie.Screen, io::IOStream, ::MIME{Symbol("image/png")}, scene::Scene)
    @ Makie C:\Users\rafael.schouten\.julia\packages\Makie\Y3ABD\src\display.jl:485
  [7] (::Makie.var"#1366#1367"{Module, Bool, @Kwargs{…}, Scene, MIME{…}, Scene})(io::IOStream)
    @ Makie C:\Users\rafael.schouten\.julia\packages\Makie\Y3ABD\src\display.jl:353
  [8] open(::Makie.var"#1366#1367"{…}, ::String, ::Vararg{…}; kwargs::@Kwargs{})
    @ Base .\io.jl:410
  [9] open
    @ .\io.jl:407 [inlined]
 [10] save(file::File{…}, fig::Scene; size::Tuple{…}, resolution::Nothing, backend::Module, update::Bool, screen_config::@Kwargs{…})
    @ Makie C:\Users\rafael.schouten\.julia\packages\Makie\Y3ABD\src\display.jl:344
 [11] save(filename::String, fig::Scene; args::@Kwargs{…})
    @ Makie C:\Users\rafael.schouten\.julia\packages\Makie\Y3ABD\src\display.jl:304
 [12] save
    @ C:\Users\rafael.schouten\.julia\packages\Makie\Y3ABD\src\display.jl:301 [inlined]
 [13] render_rpr(m::Tyler.Map{LScene}, name::String, radiance::Int64)
    @ Main c:\Users\rafael.schouten\.julia\dev\Tyler\docs\src\map-3d.md:81
 [14] top-level scope
    @ c:\Users\rafael.schouten\.julia\dev\Tyler\docs\src\map-3d.md:113
Some type information was truncated. Use `show(err)` to see complete types.

[jkrumbiegel]

That field only exists on a 3D camera, and your scene has a PixelCamera. As this scene comes from inside a Tyler created object I assume something changed there in the meantime.

[rafaqz]

Ahh so this is a Tyler bug. @SimonDanisch

[ffreyer]

The Camera object (i.e. scene.camera, always exists) also effectively holds a copy of those fields

Makie.jl/src/types.jl

Lines 292 to 303 in d6fdf25

	"""
	Direction in which the camera looks.
	"""
	view_direction::Observable{Vec3f}
	"""
	Eye position of the camera, used for e.g. ray tracing.
	"""
	eyeposition::Observable{Vec3f}
	"""
	Up direction of the current camera (e.g. Vec3f(0, 1, 0) for 2d)
	"""
	upvector::Observable{Vec3f}

Iirc I added view_direction for lighting in GLMakie at some point, and Simon needed upvector for FastPixel scatter in 3D. We should just use thisin RPRMakie too. We also talked about swapping view_direction = lookat - eyeposition for lookat to directly mirror Camera3D, but didn't get to it yet.

[ffreyer]

This should just require a switch from scene.camera_controls to scene.camera in RPRMakie and maybe an update of the camera in Tyler.