Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shopify Adapter: Raw Cart wrong typing #62

Open
Cyklan opened this issue Aug 24, 2022 · 0 comments
Open

Shopify Adapter: Raw Cart wrong typing #62

Cyklan opened this issue Aug 24, 2022 · 0 comments

Comments

@Cyklan
Copy link
Contributor

Cyklan commented Aug 24, 2022

When using the useShopCart hook from storefront-react, Typescript tells me the rawCart looks like this: https://github.com/MakairaIO/storefront-shop-adapter/blob/stable/packages/storefront-shop-adapter-shopify/src/types.ts#L50

However, the actual type signature of the raw cart looks like this:

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cyklan