Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajout sur F-Droid #47

Open
1 of 2 tasks
Altonss opened this issue Apr 6, 2024 · 5 comments
Open
1 of 2 tasks

Ajout sur F-Droid #47

Altonss opened this issue Apr 6, 2024 · 5 comments

Comments

@Altonss
Copy link

Altonss commented Apr 6, 2024

Ce serait utile si cette application était disponible dans le magasin https://f-droid.org/. Je pense qu'il ne manque plus beaucoup de choses pour que cela soit possible (un premier scan a été effectué ici: https://gitlab.com/fdroid/rfp/-/issues/2709#note_1849359210):

Il faudrait aussi vérifier si la licence de Here pour la cartographie est compatible avec l'inclusion dans F-Droid.

@licaon-kter
Copy link

licaon-kter commented Apr 8, 2024

Will the app build if we remove the gms entries in .gradle files but also firebase entries from https://github.com/MaisClement/Navika_App/blob/master/pubspec.yaml ? I kinda doubt that

Fastlane structure for pics and icon and etc ( https://gitlab.com/-/snippets/1895688 ) would be nice

@Altonss
Copy link
Author

Altonss commented Apr 8, 2024

Will the app build if we remove the gms entries in .gralde files but also forebase entries from https://github.com/MaisClement/Navika_App/blob/master/pubspec.yaml ? I kinda doubt that

From the readme, it seems that at least Firebase isn't essential: https://github.com/MaisClement/Navika_App#firebase

@licaon-kter
Copy link

licaon-kter commented Apr 8, 2024

that's not what I've asked 😜

plenty of code references Firebase

@Altonss
Copy link
Author

Altonss commented Apr 8, 2024

plenty of code references Firebase

Well, then I don't understand this sentence 😅 from the readme: Navika use firebase for notifications. Firebase is not required to build the app, you can safely disable it.

@licaon-kter
Copy link

licaon-kter commented Apr 8, 2024

eg. we remove firebase from the dependencies, then we try to build this https://github.com/MaisClement/Navika_App/blob/v1.3.3/lib/main.dart#L3 or https://github.com/MaisClement/Navika_App/blob/v1.3.3/lib/main.dart#L17 will error out since it's referenced but now not found

yes, "used or not" in the app is different compared to "needed to be able to actually build the app"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants