Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to hifitime for time keeping #50

Open
gsleap opened this issue Jul 24, 2022 · 0 comments
Open

Migrate to hifitime for time keeping #50

gsleap opened this issue Jul 24, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@gsleap
Copy link
Member

gsleap commented Jul 24, 2022

From Chirs Jordan: "I'm not sure how familiar you are with the rust library hifitime. We're using it in Marlu (and onwards) and it's wonderful; you can represent timestamps with nanosecond precision (hifitime::Epoch) and the struct methods allow you to convert to whatever (GPS, MJD, JD etc.). So, it might make sense to eventually use this as the single time-keeping method in the mwalib context structs, rather than having multiple time formats and things like seconds and milliseconds. Time resolutions etc. can be represented by hifitime::Duration, and this has the advantage of tracking units internally. I guess the trickiest part would be FFI; it's probably not worth exposing hifitime types to FFI callers, but you could convert to whatever you needed at the boundary. Just some food for thought."

@gsleap gsleap added the enhancement New feature or request label Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant