Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH dwidenoise: Write out variance explained map #3058

Open
tsalo opened this issue Jan 2, 2025 · 2 comments
Open

ENH dwidenoise: Write out variance explained map #3058

tsalo opened this issue Jan 2, 2025 · 2 comments
Labels

Comments

@tsalo
Copy link

tsalo commented Jan 2, 2025

Is your feature request related to a problem? Please describe.
It would be awesome if dwidenoise could write out a variance explained map. This stems from nipreps/fmriprep#3395 (comment).

Describe the solution you'd like
Maybe this could be a new parameter, like -varex <filename>.

Describe alternatives you've considered
Users can probably calculate variance explained pretty easily (at least for fMRI), but this would make it easier for them.

@Lestropie
Copy link
Member

Added to #3023.

What might a use case look like? Would it be most convenient for an output image to contain the fraction of variance that was removed, or the fraction that was retained?

I'm hoping that in the case of optimal shrinkage, an inner product between weights and eigenvalues is all that is required.

@tsalo
Copy link
Author

tsalo commented Jan 6, 2025

I think the fraction of variance removed would be more useful than the fraction retained. In QSIPrep and fMRIPrep, I would probably mainly use it for a figure in the HTML report, where seeing the removed variance could be clearer than the retained variance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants